Skip to content

Update a bunch of libraries#7499

Merged
litetex merged 2 commits intoTeamNewPipe:devfrom
TacoTheDank:bumpVersions
Dec 18, 2021
Merged

Update a bunch of libraries#7499
litetex merged 2 commits intoTeamNewPipe:devfrom
TacoTheDank:bumpVersions

Conversation

@TacoTheDank
Copy link
Member

@TacoTheDank TacoTheDank commented Dec 5, 2021 •
edited
Loading

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Update Gradle 7.1.1 -> 7.3.1 using git bash (changelog)
  • Update google-auto-service 1.0 -> 1.0.1 (changelog)
  • Update Mockito 3.6.0 -> 4.0.0 (changelog)
  • Update ConstraintLayout 2.0.4 -> 2.1.2 (changelog)
  • Update Google Material 1.2.1 -> 1.4.0 (changelog)
  • Update Jsoup 1.13.1 -> 1.14.3 (changelog)
  • Update RxJava3 3.0.7 -> 3.0.13 (changelog)
  • Update PrettyTime 5.0.1.Final -> 5.0.2.Final (changelog)
  • Update AndroidX Test Junit 1.1.2 -> 1.1.3 (changelog)
  • Remove unused Espresso testing library

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

XiangRongLin
XiangRongLin reviewed Dec 6, 2021
View reviewed changes
Copy link
Collaborator

@XiangRongLin XiangRongLin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build is failing.

Did you check for API changes?

@litetex litetex marked this pull request as draft December 7, 2021 21:00
@litetex

This comment has been minimized.

Sign in to view
@TacoTheDank
Copy link
Member Author

TacoTheDank commented Dec 8, 2021 •
edited
Loading

Kotlin 1.6 was changing how AndroidX Room was working, see here: https://developer.android.com/jetpack/androidx/releases/room#2.4.0-rc01. We should wait for AndroidX Room 2.4.0 before upgrading to Kotlin 1.6.

@TacoTheDank
Copy link
Member Author

TacoTheDank commented Dec 9, 2021

Added runners library non-transitively to resolve androidx.test.filters.LargeTest in ErrorInfoTest.

@TacoTheDank TacoTheDank marked this pull request as ready for review December 9, 2021 00:34
@triallax triallax added the codequality Improvements to the codebase to improve the code quality label Dec 9, 2021
@TacoTheDank
Copy link
Member Author

TacoTheDank commented Dec 11, 2021

Did you check for API changes?

Seems I somehow missed this: yes :) everything looks good, I didn't see anything in the changelogs that was noteworthy or that required code changes.

@litetex
Copy link
Member

litetex commented Dec 12, 2021

@TacoTheDank
I noticed that the APK is now ~600kB bigger than before. Do you know where that comes from?

litetex
litetex reviewed Dec 12, 2021
View reviewed changes
Copy link
Member

@litetex litetex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a quick test, LGTM.

If my comment above is clarified the PR get's my approval

@TacoTheDank
Copy link
Member Author

TacoTheDank commented Dec 13, 2021

@TacoTheDank I noticed that the APK is now ~600kB bigger than before. Do you know where that comes from?

So I analyzed "before" and "after" APKs...

Results: Google Material resources be getting thicc 😔

Also, I bumped AGP to 7.0.4 because it just got released.

litetex
litetex approved these changes Dec 14, 2021
View reviewed changes
Copy link
Member

@litetex litetex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@litetex litetex merged commit e8d9095 into TeamNewPipe:dev Dec 18, 2021
@TacoTheDank TacoTheDank deleted the bumpVersions branch December 19, 2021 21:35
@litetex litetex mentioned this pull request Jan 9, 2022
Closed
4 tasks
This was referenced Feb 11, 2022
Closed
Merged
@TacoTheDank TacoTheDank mentioned this pull request Feb 26, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@XiangRongLin XiangRongLin XiangRongLin left review comments

@litetex litetex litetex approved these changes

Assignees

No one assigned

Labels

codequality Improvements to the codebase to improve the code quality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TacoTheDank @litetex @XiangRongLin @triallax

Comments